[CDAP-21093] Add errorCodeType, errorCode & supportedDocURL in exception (MySQL) #530
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
changed the title
| @@ -76,7 +78,8 @@ private ProgramFailureException getProgramFailureException(SQLException e, Error | |||
| externalDocumentationLink); | |||
| } | |||
| return ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | |||
| errorMessage, errorMessageWithDetails, getErrorTypeFromErrorCode(errorCode), false, e); | |||
| errorMessage, errorMessageWithDetails, getErrorTypeFromErrorCode(errorCode), false, ErrorCodeType.SQLSTATE, | |||
| sqlState, DBUtils.MYSQL_SUPPORTED_DOC_URL, e); | |||
There was a problem hiding this comment.
The supported doc url should come from child class, we cannot hardcoded mysql.
There was a problem hiding this comment.
🤦 typo, Fixed !
Tested Again
psainics
force-pushed
the
patch/errorCodeTypeExtention
branch
from
1d0fb5c to
98792ac
Compare
psainics
force-pushed
the
patch/errorCodeTypeExtention
branch
from
98792ac to
5c958cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add errorCodeType, errorCode & supportedDocURL in exception
Jira : CDAP-21093
Description
Adding errorCodeType, errorCode & supportedDocURL in exception for mysql, and command
DBErrorDetailsProviderclassCode change
DBErrorDetailsProvider.javaDBRecord.javaDBUtils.javaMysqlErrorDetailsProvider.javaTest