[PLUGIN-1829] Add CloudSQLMySQLErrorDetailsProvider #526
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * A custom ErrorDetailsProvider for CloudSQL MySQL plugins. | ||
| */ | ||
| public class CloudSQLMySQLErrorDetailsProvider extends DBErrorDetailsProvider { |
There was a problem hiding this comment.
why can't it just extend MySQLErrorDetailsProvider?
There was a problem hiding this comment.
Good, this will save duplicate code. 👍
Updated !
psainics
force-pushed
the
fem/cloudsql-mysql
branch
from
5c0029e to
d6618f1
Compare
|
|
||
| @Override | ||
| protected String getExternalDocumentationLink() { | ||
| return "https://dev.mysql.com/doc/mysql-errors/9.0/en/ ,https://cloud.google.com/sql/docs/mysql/error-messages"; |
There was a problem hiding this comment.
Lets only use one link https://cloud.google.com/sql/docs/mysql/error-messages, the mysql one is mentioned in the cloud sql one anyways.
psainics
force-pushed
the
fem/cloudsql-mysql
branch
from
d6618f1 to
9bfd764
Compare
itsankit-google
approved these changes
Dec 16, 2024
psainics
force-pushed
the
fem/cloudsql-mysql
branch
from
9bfd764 to
2705f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorDetailsProvider - CloudSQLMySQL [Source|Sink] plugin
Jira : PLUGIN-1829
Description
Implement Program Failure Exception Handling in CloudSQLMySQL Source/Sink plugin to catch known errors
Code change
CloudSQLMySQLErrorDetailsProvider.javaCloudSQLMySQLSink.javaCloudSQLMySQLSource.javaE2E Changes
Open and capture logsstep when pipeline is expected to fail.