Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append functionality for write_hdf5 #32

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Conversation

lbluque
Copy link
Contributor

@lbluque lbluque commented Jul 19, 2016

This addresses #29 for write_hdf5. Opening this PR for comments and suggestions for including append functionality.

@lbluque
Copy link
Contributor Author

lbluque commented Jul 19, 2016

For .npy files there is no clean way of doing it. But I doubt users will want to write a very large array (that requires chunking) into a .npy file (which can only be loaded completely, hence defeating the purpose of saving memory). So I suggest to not even go down that road.
Butit would be nice to include append functionality in write_dxf

@decarlof
Copy link
Collaborator

@lbluque thank you for your contribution. I will look at the write_dxf. The dxfile at dxfile subclasses the h5py module so should already handle the append.

@decarlof decarlof merged commit 908d0c4 into data-exchange:master Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants