-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes/enhancement to ALS readers #25
Conversation
@@ -157,7 +158,8 @@ def read_als_832(fname, ind_tomo=None, normalized=False): | |||
ind_dark = list(range(0, ndark)) | |||
|
|||
# Read image data from tiff stack. | |||
tomo = dxreader.read_tiff_stack(tomo_name, ind=ind_tomo, digit=4) | |||
tomo = dxreader.read_tiff_stack(tomo_name, ind=ind_tomo, digit=4, | |||
slc=(sino, None)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know this code, but that sometime you are using (sino, None)
and other time (None, sino)
is a really bad code smell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tacaswell it does smell bad ... thank you for point it out. For some reason we are flipping the order between datasets consisting of multiple files (tiff, xrm) vs single files (hdf, netcdf etc.). We should make it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgursoy fix seems easy, just swap the loop indexing at
def _shape_after_slice(shape, slc):
but will make it not back compatible. Suggestions?
@lbluque passed the reconstruction tests on both ALS tiff and hdf5. @tacaswell do you have a suggestion on how to run automatic testing with large data sets? |
To generate synthetic data if possible, use minimal files if possible (ex a 10x10x10 tomographic dataset). In this case, it might require a writer for each of these layouts. |
@lbluque I updated the docs to include two examples for reading and reconstructing the ALS data. This are at ALS examples with functions showing at API Feel free to add/modify as needed |
@lbluque I am merging and closing this pull request. If you want to add more info in the documentation at ALS examples please open a new pull request. |
Small fixes/enhancement include: