feat(mui5):introducing isFilterCaseInSensitive prop for dual-list-select filterOption #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rvsia
reviewed
Jul 8, 2024
| @@ -26,6 +26,7 @@ interface InternalDualListSelectProps { | |||
| filterOptionsText?: ReactNode; | |||
| leftValues?: DualListSelectValue[]; | |||
| rightValues?: DualListSelectValue[]; | |||
| isFilterCaseInSensitive?: boolean; | |||
There was a problem hiding this comment.
I would suggest to not use prop for it and set it as a default behavior.
@Hyperkid123 what do you think?
There was a problem hiding this comment.
Raising new PR: #1473, closing this one.
|
Raised a new one: #1473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change.
introducing isFilterCaseInSensitive prop for dual-list-select filterOption.
isFilterCaseInSensitive : false -> Filtering would be Case sensitive, CaTs would not match with cats.
isFilterCaseInSensitive : true -> Filtering would not be Case sensitive, CaTs would match with cats.
Schema (if applicable)
export default {
"fields": [
{
"component": "customDualList",
"name": "MUI",
"isFilterCaseInSensitive":true,
"options": [
{
"value": "cats",
"label": "cats"
},
{
"value": "cats_1",
"label": "cats_1"
},
{
"value": "cats_2",
"label": "cats_2"
},
{
"value": "zebras",
"label": "zebras"
},
{
"value": "pigeons",
"label": "pigeons"
}
]
}
]
};
Checklist: (please see documentation page for more information)
Yarn buildpassesYarn lintpassesYarn testpassesfix|feat({scope}): {description}fix(pf3): wizard correctly handles next buttonFix button on documenation example page