Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent isFetching bug in useSelect #1450

Closed
wants to merge 1 commit into from
Closed

Prevent isFetching bug in useSelect #1450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/common/src/use-select/reducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@
...state,
isInitialLoaded: true,
};
case 'setPromises':
case 'setPromises': {
const compareValues = payload.compareValues;
delete payload.compareValues;

return {
...state,
promises: {
Expand All @@ -42,16 +45,15 @@
options: optionsTransformer
? optionsTransformer([
...state.options,
...options.filter(({ value }) => !state.options.find((option) => payload.compareValues(option.value, value))),
...options.filter(({ value }) => !state.options.find((option) => compareValues(option.value, value))),

Check warning on line 48 in packages/common/src/use-select/reducer.js

View check run for this annotation

Codecov / codecov/patch

packages/common/src/use-select/reducer.js#L48 

Added line #L48 was not covered by tests
])
: [...state.options, ...options.filter(({ value }) => !state.options.find((option) => payload.compareValues(option.value, value)))],
: [...state.options, ...options.filter(({ value }) => !state.options.find((option) => compareValues(option.value, value)))],
...(optionsTransformer && {
originalOptions: [
...state.options,
...options.filter(({ value }) => !state.options.find((option) => payload.compareValues(option.value, value))),
],
originalOptions: [...state.options, ...options.filter(({ value }) => !state.options.find((option) => compareValues(option.value, value)))],

Check warning on line 52 in packages/common/src/use-select/reducer.js

View check run for this annotation

Codecov / codecov/patch

packages/common/src/use-select/reducer.js#L52 

Added line #L52 was not covered by tests
}),
};
}

default:
return state;
}
Expand Down
Loading