fix(all): replace defaultProps with inline function defaults #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rvsia
reviewed
Jan 23, 2024
| @@ -28,7 +28,7 @@ const useStyles = createUseStyles({ | |||
| }, | |||
| }); | |||
|
|
|||
| const List = ({ value, optionClick, noOptionsTitle, filterValue, filterValueText, selectedValues, MenuProps, MenuItemProps }) => { | |||
| const List = ({ value = {}, optionClick, noOptionsTitle, filterValue, filterValueText, selectedValues, MenuProps = {}, MenuItemProps = {} }) => { | |||
| cancelLabel: 'Cancel', | ||
| resetLabel: 'Reset', | ||
| canReset: false, | ||
| canSubmit: false, |
There was a problem hiding this comment.
It's been moved to the FormControls argument defaults.
Hyperkid123
force-pushed
the
default-props
branch
from
bf48313 to
c0eb916
Compare
rvsia
approved these changes
Jan 24, 2024
|
🎉 This PR is included in version 3.22.3 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1439
@rvsia this will need proper validation