Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pf4): fix date and time picker change attributes order #1436

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Hyperkid123
Copy link
Member

Fixes #1432

Description

Fix the order of the pickers attributes sent to the change callback

@Hyperkid123 Hyperkid123 added bug Something isn't working PF4 PF4 pull request labels Jan 8, 2024
@Hyperkid123 Hyperkid123 requested review from rvsia and fhlavac January 8, 2024 08:38
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 8:42am

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2dce5f0) 94.92% compared to head (c05811a) 94.88%.
Report is 1 commits behind head on master.

Files Patch % Lines
...f4-component-mapper/src/date-picker/date-picker.js 66.66% 1 Missing ⚠️
...f4-component-mapper/src/time-picker/time-picker.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   94.92%   94.88%   -0.05%     
==========================================
  Files         210      210              
  Lines        3706     3711       +5     
  Branches     1292     1295       +3     
==========================================
+ Hits         3518     3521       +3     
- Misses        188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvsia rvsia merged commit 8f59331 into master Jan 8, 2024
4 of 6 checks passed
@rvsia rvsia added the released label Jan 8, 2024
@Hyperkid123 Hyperkid123 deleted the pf4-date-picker branch March 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatternFly DatePicker does not select value
2 participants