Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderer): allow condition mapping #1424

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Hyperkid123
Copy link
Member

fixes #1418

@Hyperkid123 Hyperkid123 requested a review from rvsia November 7, 2023 14:57
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 0:31am

@DataDrivenFormsBot
Copy link

A new version (feat) will be released: v3.22.0 [DataDrivenFormsBot]

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1424 (12e1201) into master (b8c41c5) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 91.83%.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   94.96%   94.91%   -0.05%     
==========================================
  Files         210      210              
  Lines        3672     3697      +25     
  Branches     1284     1289       +5     
==========================================
+ Hits         3487     3509      +22     
- Misses        185      188       +3     
Files Coverage Δ
...ges/react-form-renderer/src/condition/condition.js 98.27% <100.00%> (+0.06%) ⬆️
...t-form-renderer/src/form-renderer/form-renderer.js 90.47% <100.00%> (+0.15%) ⬆️
...rm-renderer/src/parse-condition/parse-condition.js 100.00% <100.00%> (+1.78%) ⬆️
...fault-schema-validator/default-schema-validator.js 95.93% <73.33%> (-3.23%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Hyperkid123 Hyperkid123 force-pushed the mapped-attibutes-condition branch from 24db50a to 9929f9f Compare November 8, 2023 09:00
@Hyperkid123 Hyperkid123 marked this pull request as ready for review November 8, 2023 09:01
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, could we also please add documentation for that functionality? 😊

@rvsia rvsia added the renderer React form renderer PR label Nov 8, 2023
@Hyperkid123 Hyperkid123 force-pushed the mapped-attibutes-condition branch 2 times, most recently from 9751de5 to 6901bab Compare November 8, 2023 12:23
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hyperkid123 Hyperkid123 merged commit e1b5f8d into master Nov 10, 2023
4 of 6 checks passed
@Hyperkid123 Hyperkid123 deleted the mapped-attibutes-condition branch November 10, 2023 08:31
@rvsia rvsia added the released label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Is it possible to use a custom function for conditions within the schema in JSON format?
3 participants