fix(TS): no-index type to exclude [otherProp: string]: any;

[stijnvanhulle]

Description

Final-form-api is using FormProps with [otherProp: string]: any;. If you then use Omit it will resolve in [otherProp: string]: any; and all other types will not be visible anymore.

Typescript playground

By using NoIndex we can exclude [otherProp: string]: any; and have all the types that we normally have in FormProps.

Related

• Omit seems broken on type extending Record microsoft/TypeScript#50638
• Exclude not work on [key: string]:any microsoft/TypeScript#31153 (comment)

Both of them are closed with some examples on how to fix it but it seems that the TypeScript team will not fix the Omit. 👎🏼

Checklist: (please see documentation page for more information)

• Yarn build passes
• Yarn lint passes
• Yarn test passes
• Test coverage for new code (if applicable)
• Documentation update (if applicable)
• Correct commit message
  • format fix|feat({scope}): {description}
  • i.e. fix(pf3): wizard correctly handles next button
  • fix will release a new _._.X version
  • feat will release a new _.X._ version (use when you introduce new features)
    • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
  • scope: package
  • if you update the documentation or tests, do not use this format
    • i.e. Fix button on documenation example page

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
react-forms	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 21, 2023 at 7:29PM (UTC)

[DataDrivenFormsBot]

A new version (fix) will be released: v3.20.4 [DataDrivenFormsBot]

[codecov]

Codecov Report

Merging #1373 (1a918e0) into master (7aa9bb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         210      210           
  Lines        3647     3647           
  Branches     1271     1271           
=======================================
  Hits         3468     3468           
  Misses        179      179           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rvsia]

🎉 This PR is included in version 3.20.4 🎉

The release is available on

• react-form-renderer (@latest dist-tag)

• ant-component-mapper (@latest dist-tag)

• blueprint-component-mapper (@latest dist-tag)

• carbon-component-mapper (@latest dist-tag)

• mui-component-mapper (@latest dist-tag)

• pf4-component-mapper (@latest dist-tag)

• suir-component-mapper (@latest dist-tag)

Data-Driven-Forms.org!