Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare enums explicitly, fix type hints #74

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Declare enums explicitly, fix type hints #74

merged 6 commits into from
Jul 29, 2022

Commits on Jul 28, 2022

  1. Declare enums explicitly, fix hints 

    Signed-off-by: Vasily Litvinov <[email protected]>
    @vnlitvinov @rgommers
    vnlitvinov authored and rgommers committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    8eab8a2 View commit details
    Browse the repository at this point in the history

  2. Align spec with existing implementations 

    Signed-off-by: Vasily Litvinov <[email protected]>
    @vnlitvinov @rgommers
    vnlitvinov authored and rgommers committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2b35e5d View commit details
    Browse the repository at this point in the history

  3. Format the spec with black 

    Signed-off-by: Vasily Litvinov <[email protected]>
    @vnlitvinov @rgommers
    vnlitvinov authored and rgommers committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    6b49f22 View commit details
    Browse the repository at this point in the history

  4. Change API a bit, align formatting with pandas 

    Signed-off-by: Vasily Litvinov <[email protected]>
    @vnlitvinov @rgommers
    vnlitvinov authored and rgommers committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d772b47 View commit details
    Browse the repository at this point in the history

  5. Remove NaT (not-a-datetime) from the USE_NAN description. 

    This address the review comment that NaT is not a thing outside of
NumPy. Hence for not-a-datetime, all implementers should be using
sentinel values, because those are explicit.
    @rgommers
    rgommers committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    0e9e173 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Change Column.size from a property to a method

    @rgommers
    rgommers committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    f1f1eac View commit details
    Browse the repository at this point in the history