Add dataframe.collect #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
reviewed
Aug 2, 2023
| @@ -838,3 +838,16 @@ def to_array_object(self, dtype: Any) -> Any: | |||
| understanding that consuming libraries would then use the | |||
| ``array-api-compat`` package to convert it to a Standard-compliant array. | |||
| """ | |||
|
|
|||
| def collect(self) -> Any: | |||
There was a problem hiding this comment.
Existing APIs of lazy dataframes look quite different and the equivalent of the collect() function accepts various implementation-specific kwargs 1, 2.
Can it be assumed that each library has "reasonable defaults" that will work for most use-cases, and those can be used in their implementations of collect()? (I think it can, but just making sure we consider this).
There was a problem hiding this comment.
Also should this be part of DataFrame, or should a new LazyFrame interface be introduced?
|
closing as this is being addressed by #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has come up in a few discussions
closes #120