✨: create init file #12
Draft
+476
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstarman
commented
Dec 5, 2024
jorenham
reviewed
Dec 5, 2024
src/array_api_typing/_version.py
Outdated
| # This file is automatically generated by Hatch | ||
| version = '0.1.dev5+g9027b7d.d20241205' | ||
| version_tuple = (0, 1, 'dev5', 'g9027b7d.d20241205') | ||
|
|
There was a problem hiding this comment.
I'm guessing this red steering wheel is trying to tell us that there's a trailing newline missing
jorenham
reviewed
Dec 5, 2024
jorenham
reviewed
Dec 5, 2024
| @@ -0,0 +1,5 @@ | |||
| """Static typing support for the array API standard.""" | |||
|
|
|||
| __all__: list[str] = [] | |||
There was a problem hiding this comment.
alternative workaround for type-checkers that still don't realize that __all__ is always a sequence of str in 2024:
Suggested change
| __all__: list[str] = [] | |
| __all__ = () |
jorenham
reviewed
Dec 5, 2024
src/array_api_typing/_version.py
Outdated
Comment on lines
2
to
3
| version = '0.1.dev5+g9027b7d.d20241205' | ||
| version_tuple = (0, 1, 'dev5', 'g9027b7d.d20241205') |
There was a problem hiding this comment.
why does it start counting at 5 🤔 ?
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Co-authored-by: Joren Hammudoglu <[email protected]> Signed-off-by: Nathaniel Starkman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.