Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for branching in tables _join #613

Merged

Conversation

rwmehta
Copy link
Contributor

@rwmehta rwmehta commented May 30, 2024

[X] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
Added tests for if and if not branches in tables _join method as requested in issue #476 .
Ensures the method returns None when either table has no rows, and matches the label when "other_label" is not provided.

@coveralls
Copy link

Coverage Status

coverage: 94.976%. remained the same
when pulling 572b08f on rwmehta:rwmehta/test-coverage-table-join
into 0c82a19 on data-8:master.

@davidwagner
Copy link
Member

This doesn't seem to increase test coverage. I think these cases are already covered by other pre-existing test cases: empty tables by test_join_no_rows(), and no 3rd argument to join by many other test cases. But OK, why not, more tests can't hurt. Thanks for the contribution.

@davidwagner davidwagner merged commit cf403b5 into data-8:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants