Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing to test_maps.py #607

Closed
wants to merge 1 commit into from
Closed

Added testing to test_maps.py #607

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2024

[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
Added additional tests to tests_maps.py to increase testing as stated on #476.

@adnanhemani
Copy link
Member

As shown by the CI/CD results, I don't think this code was properly tested locally prior to being raised as a PR here. Please ensure that any code you push here (for the sake of being a reasonable use of maintainers' efforts) does the following: 1) passes all unit testing and 2) increases the test coverage of the repository. This is not explicitly mentioned anywhere in this repo as it is Open Source standard - and general, good practice.

I will keep this PR open for a week to allow you to make any further changes for a chance to revise this code.

Repository owner closed this by deleting the head repository Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants