Add coverage tests for tables.py #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanhemani
requested changes
Dec 23, 2022
tests/test_tables.py
Outdated
| @@ -1157,6 +1157,9 @@ def test_remove_column_type(table): | |||
| # Create # | |||
| ########## | |||
|
|
|||
| def test_empty_labels_none(): | |||
There was a problem hiding this comment.
I think you've actually stumbled on a bug here - this shouldn't have thrown an Error. Can you remove this test case and I'll create a ticket in the backlog to remove this method altogether.
There was a problem hiding this comment.
Update: I've solved this bug in #570
|
Closing this review as none of the test cases added are applicable to the code as it stands now. Thank you for your efforts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md
Changes proposed:
Added coverage tests to tables.py for issue #476