Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

add paging to file list #370

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add paging to file list #370

wants to merge 2 commits into from

Conversation

joehand
Copy link
Contributor

@joehand joehand commented Jan 11, 2017

Starts adding paging to file list. Depends on yo-fs PR. Currently looks like this:

screen shot 2017-01-11 at 12 19 10

Much style!

Notes:

  • I set the current page limit to 5 for easier testing. We can increase this before merging.
  • Has prev/next buttons to control paging.

TODO:

  • Merge yo-fs PR
  • Figure out how to style

@okdistribute
Copy link
Collaborator

okdistribute commented Feb 23, 2017

hey @joehand thanks for working on this ! Sorry it never moved forward.

As far as styling goes, it makes sense to me to leave it relatively unstyled in yo-fs to make sure that folks can restyle it as they please.

@Kriesse
Copy link
Contributor

Kriesse commented Jun 15, 2017

@joehand @Karissa What's the status of this? Is just styling missing from it to be merged?

@joehand
Copy link
Contributor Author

joehand commented Jun 15, 2017

We were waiting for the new hyperdrive, which is now out. This issue has a bit more discussion.

Part of the blocker was that the metadata download was too slow before. We are still fetching the whole metadata upfront, but this is probably fine now. To move forward I could:

  1. Update this PR and merge as is (with the full metadata fetch)
  2. Change to partial metadata fetching and update PR (bigger task, but better long-run)

@okdistribute
Copy link
Collaborator

Nice, thanks for circling back around on this @joehand ..
I'd say do the first one, and then open an issue for making it more efficient.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants