This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
Styles #141
Merged
Styles #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace pngs with svgs update dat-design clean up scss and remove unused styles
# Conflicts: # src/scss/main.scss
# Conflicts: # src/scss/main.scss
…or stays neutral, which helps with adjusting text colors for legibility etc.)
|
no worries, I will do the untangling today! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has a lot of cleanups in the mains.scss (removing unused styles, rewriting vanilla css to make use of scss nesting and variables, add a little breakpoint testing class).
I also started to style the header and dat layout to look like the mockups and reuse styles already built for dat-desktop.
This might overlap and not merge well with the ongoing work in the header branch – let me know if I can help to untangle.