-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Ephemeral message extension #28
Closed
pfrazee
wants to merge
9
commits into
dat-ecosystem-archive:master
from
pfrazee:ephemeral-msg-extension
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fb8c7d2
Add proposals/0000-ephemeral-message.md
pfrazee 9d092b4
Set PR link on proposals/0000-ephemeral-message.md
pfrazee e683b60
Fix copy-pasta typos in proposals/0000-ephemeral-message.md
pfrazee c2bdace
Added a header with 'encoding' values and increased the max payload s…
pfrazee 7fc180a
Change the message identifier to 'ephemeral'
pfrazee 5299afb
Add more to the motivation of proposals/0000-ephemeral-message.md
pfrazee 630a691
Change the payload encoding to protobuf and provide a more flexible c…
pfrazee c7e10ac
Add size-limit suggestion to ephemeral-message DEP
pfrazee b115233
Add "Privacy, security, and reliability" section
pfrazee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
|
||
Title: **DEP-0000: Ephemeral Message (Extension Message)** | ||
|
||
Short Name: `0000-ephemeral-message-extension` | ||
|
||
Type: Informative | ||
|
||
Status: Undefined (as of 2018-06-05) | ||
|
||
Github PR: https://github.com/datprotocol/DEPs/pull/28 | ||
|
||
Authors: [Paul Frazee](https://github.com/pfrazee) | ||
|
||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
This DEP defines the non-standard `ephemeral` extension message used in the Dat replication protocol. This message provides a way to send arbitrary application data to a peer through an existing connection. | ||
|
||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
While Dat is effective at sharing persistent datasets, applications frequently need to transmit extra information which does not need to persist. This kind of information is known as "ephemeral." Examples include: sending chat messages, proposing changes to a dat, alerting peers to events, broadcasting identity information, and sharing the URLs of related datasets. | ||
|
||
This DEP was motivated by the need for a quick solution to these use-cases. It establishes a mechanism for sending ephemeral messages over existing Dat connections. At time of writing, it is unclear whether this mechanism will be used in the long-term, or superseded by a more flexible messaging channel. | ||
|
||
A specific use case for this extension is to enable a new Web API which will expose peer message-passing channels to in-browser applications. Such an API would restrict access so that the application code of a `dat://` site will only be able to send ephemeral messages on connections related to its own content. | ||
|
||
|
||
# Reference Documentation | ||
[reference-documentation]: #reference-documentation | ||
|
||
This DEP is implemented using the Dat replication protocol's "extension messages." In order to broadcast support for this DEP, a client should declare the `'ephemeral'` extension in the replication handshake. | ||
|
||
Ephemeral messages can be sent at any time after the connection is established by sending an extension message of type `'ephemeral'`. The message payload is a protobuf with the following schema: | ||
|
||
``` | ||
message EphemeralMessage { | ||
optional string contentType = 1; | ||
required bytes payload = 2; | ||
} | ||
``` | ||
|
||
The `contentType` string should provide a valid MIME type. If none is specified, the encoding should be considered `application/octet-stream`. | ||
|
||
The client may respond to the message by emitting an event, so that it may be handled by the client's application logic. No acknowledgment of receipt will be provided (no "ACK"). | ||
|
||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
- This DEP may present privacy concerns, as it may be used to track users in a similar fashion to HTTP Cookies, or be used to exfiltrate data. | ||
- The payload of the `'ephemeral'` message is not authenticated in any way. The lack of trust must be considered by applications which leverage the data. | ||
- If the recipient of the `'ephemeral'` message is not authenticated (as is currently the case in all Dat replication connections) the client will not know who is receiving the payload and may broadcast sensitive information. | ||
|
||
|
||
# Changelog | ||
[changelog]: #changelog | ||
|
||
- 2018-06-10: Change the payload encoding to protobuf and provide a more flexible content-type field. | ||
- 2018-06-10: Expand on the motivation of this DEP | ||
- 2018-06-10: Change the message identifier to `'ephemeral'` | ||
- 2018-06-05: Added a header with 'encoding' values and increased the max payload size from 256b to 10kb. | ||
- 2018-06-05: First complete draft submitted for review | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding general purpose capabilities to the Dat protocol to support all these use cases, why not embed Dat withing application-specific protocols for each of these use cases? The protocol stack is pretty modular as-is, so it should be possible to borrow "just" features like discovery, stream encryption, etc. Hypercore is transport agnostic, so it should be possible to embed in each of these.
This is sort of a rhetorical/hypothetical question; what i'm really getting at is, are we trying to turn the hypercore protocol a general purpose distributed networking framework? If so, maybe we should draw up a roadmap of what that would entail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beaker needs a quick solution to exchanging ephemeral messages between users that reside on a dat:// site. Hypercore has an extensions mechanism for sending arbitrary message types, and so this DEP is taking advantage of that. It's a low-effort, high-return feature; just a stepping stone to the broader roadmap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good context! I'm for pushing this through as a Draft so you can move fast but still have documentation you can point at for interop.