feat #400 - update link targets to blank

dassana-io · Jul 21, 2021 · da2d430 · da2d430
1 parent fffb930
commit da2d430
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/__snapshots__/storybook.test.ts.snap b/src/__snapshots__/storybook.test.ts.snap
@@ -3129,12 +3129,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography hiringLink-0-2-225"
             data-test="link"
             href="http://www.linkedin.com"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               We’re hiring!
@@ -3152,12 +3153,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography footerIcon-0-2-221"
             data-test="link"
             href="http://www.twitter.com"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               <svg
@@ -3183,12 +3185,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography footerIcon-0-2-221"
             data-test="link"
             href="http://www.linkedin.com"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               <svg
@@ -3214,12 +3217,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography footerIcon-0-2-221"
             data-test="link"
             href="https://github.com/dassana-io/dassana"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               <svg
@@ -3245,12 +3249,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography footerIcon-0-2-221"
             data-test="link"
             href="https://www.slack.com"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               <svg
@@ -3276,12 +3281,13 @@ exports[`Storyshots Made With Love With Love 1`] = `
             className="ant-typography footerIcon-0-2-221"
             data-test="link"
             href="https://github.com/dassana-io/dassana"
+            rel="noopener noreferrer"
             style={
               Object {
                 "WebkitLineClamp": undefined,
               }
             }
-            target="_self"
+            target="_blank"
           >
             <u>
               <svg

diff --git a/src/components/Pages/MadeWithLove.tsx b/src/components/Pages/MadeWithLove.tsx
@@ -211,6 +211,7 @@ export const MadeWithLove: FC<MadeWithLoveProps> = ({
 					<Link
 						classes={[compClasses.hiringLink]}
 						href='http://www.linkedin.com'
+						target='_blank'
 					>
 						We’re hiring!
 					</Link>
@@ -223,6 +224,7 @@ export const MadeWithLove: FC<MadeWithLoveProps> = ({
 							classes={[compClasses.footerIcon]}
 							href={href}
 							key={i}
+							target='_blank'
 						>
 							<FontAwesomeIcon icon={icon} />
 						</Link>