chore #127: Fix bug - dissapearing svg viewbox property

dassana-io · Oct 22, 2020 · ad242cd · ad242cd
1 parent 347e910
commit ad242cd
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 63 deletions.
diff --git a/src/components/Icon/IconsMap.ts b/src/components/Icon/IconsMap.ts
@@ -8,6 +8,11 @@ import { ReactComponent as QUERY_SERVICE } from '../assets/icons/query-service.s
 import { ReactComponent as SALESFORCE } from '../assets/icons/salesforce.svg'
 import { ReactComponent as ZOOM } from '../assets/icons/zoom.svg'
 
+/*
+NOTE: When you add an svg, make sure it doesn't have a predefined height and width. The viewbox property dissapears if you try to set the dimensions outside storybook. https://github.com/gregberge/svgr/issues/500
+
+TODO: Find a better rollup plugin that handles importing images as ReactComponent's. 
+*/
 const Icons = {
 	appStore: APP_STORE,
 	aws: AWS,

diff --git a/src/components/assets/icons/app-store.svg b/src/components/assets/icons/app-store.svg
diff --git a/src/components/assets/icons/aws.svg b/src/components/assets/icons/aws.svg
diff --git a/src/components/assets/icons/azure.svg b/src/components/assets/icons/azure.svg
diff --git a/src/components/assets/icons/dassana.svg b/src/components/assets/icons/dassana.svg
diff --git a/src/components/assets/icons/github.svg b/src/components/assets/icons/github.svg
diff --git a/src/components/assets/icons/google-cloud-platform.svg b/src/components/assets/icons/google-cloud-platform.svg
diff --git a/src/components/assets/icons/query-service.svg b/src/components/assets/icons/query-service.svg
diff --git a/src/components/assets/icons/salesforce.svg b/src/components/assets/icons/salesforce.svg
diff --git a/src/components/assets/icons/zoom.svg b/src/components/assets/icons/zoom.svg