Remote API error handling: expose response string #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend error handling by retrieving and providing the response string from the remote API as part of the error message returned to the caller if the status code indicates an error condition. Based on testing, the response string contains useful troubleshooting information which can help identify missing information in the submitted MessageCard payload. --- Note: This commit contains example `logger` object calls to illustrate the proposed changes mentioned in #10. Before the associated PR would be merged, those `logger` calls would be removed and implemented as part of a separate PR specific to #10. refs #10, #6 (loosely)
|
@dasrick Any feedback on this PR? codeclimate doesn't like the additional return statements, but some additional refactoring may be able to resolve that. As I mentioned, this PR also showcases some package-level |
This was referenced Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extend error handling by retrieving and providing the response string from the remote API as part of the error message returned to the caller if the status code indicates an error condition.
Based on testing, the response string contains useful troubleshooting information which can help identify missing information in the submitted
MessageCardpayload.Note
This Pull Request contains example
loggerobject calls to illustrate the proposed changes mentioned in #10. Theseloggercalls are included in this PR only for discussion purposes.Before this PR would be merged, those
loggercalls would be removed, the associated branch rebased, and those changes set aside for potential implementation as part of a separate PR specific to #10.refs #10, #6 (loosely)