Schedule a queued task when a task secedes
#7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not totally sure about this. Yielding a single value vs returning a single value from a function is 3-4x slower in Python (45ns vs 130ns on my machine). `_exit_processing_common` is pretty hot, and especially latency sensitive with fast tasks. Probably not worth worrying about, but let's profile and see.
6 tasks
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 34m 43s ⏱️ - 4m 24s For more details on these failures, see this check. Results for commit 9ad1608. ± Comparison against base commit 1db2595. ♻️ This comment has been updated with latest results. |
crusaderky
approved these changes
Oct 31, 2022
This was referenced Oct 31, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7223
pre-commit run --all-files