[WIP] Set OPENBLAS_NUM_THREADS by default
#7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 23m 48s ⏱️ - 11m 3s For more details on these failures, see this check. Results for commit 07c1fb4. ± Comparison against base commit 8f25111. |
crusaderky
approved these changes
Oct 24, 2022
fjetter
added a commit
that referenced
this pull request
Oct 23, 2023
In #5098 we set a malloc trim threshold by default to more aggressively control memory trimming. also related #7177 At the same time, we included these default settings but didn't have incredibly solid arguments for it. It's been a long standing best practice when using dask to disable this nested parallelism. We haven't received a lot of user feedback about this. However, we had some internal reports of users who were struggling with this because this was quite unexpected behavior for them and non-trivial to debug for the ordinary end user. In apache/arrow#38389 (comment) this also suggests to negatively impact read performance of parquet tables. We should consider removing this again
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://docs.dask.org/en/stable/array-best-practices.html#avoid-oversubscribing-threads we recommend setting
to avoid oversubscribing worker threads.
Today we set
OMP_NUM_THREADSandMKL_NUM_THREADSby default (when using a nanny)distributed/distributed/distributed.yaml
Lines 191 to 193 in 6ac679e
So users get good defaults by default. Should we also set
OPENBLAS_NUM_THREADS?cc @crusaderky in case you have thoughts here