Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add task prefixes to prometheus metrics #7083

Closed
wants to merge 2 commits into from

Conversation

mrocklin
Copy link
Member

@ntabris
Copy link
Contributor

ntabris commented Sep 28, 2022

Here's an example graph of the data in Grafana:

image

cc @ian-r-rose

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 40m 16s ⏱️ +23s
  3 136 tests +1    3 051 ✔️ +  3    85 💤 ±0  0  - 2 
23 206 runs  +7  22 300 ✔️ +11  906 💤  - 2  0  - 2 

Results for commit e02db9e. ± Comparison against base commit 8f36aa5.

@mrocklin
Copy link
Member Author

Context for this:

We like the task stream plot, and we'd like some version of it that could be stored long-term. The task strream plot is a bit too busy. We have attempts of this with TaskGroups. Coiled has systems internally which does this. Maybe prometheus is better for this though. This PR samples the task stream and aggregagtes the information.

This is lossy, which isn't great. We could also use counters internally and do some sort of diff in grafana. @ntabris may think about this a bit.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mrocklin
Copy link
Member Author

This is superceded by #7088 , which gives a much more accurate view. This PR effectively samples the task stream while the other tracks all results using a bit of added state.

@hendrikmakait
Copy link
Member

Superseded by #7088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants