Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --runslow implementation in conftest #6995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve --runslow implementation in conftest #6995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# https://pytest.org/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option
from __future__ import annotations

import pytest
Expand Down Expand Up @@ -27,13 +26,14 @@ def pytest_addoption(parser):


def pytest_collection_modifyitems(config, items):
if config.getoption("--runslow"):
# --runslow given in cli: do not skip slow tests
return
skip_slow = pytest.mark.skip(reason="need --runslow option to run")
# https://pytest.org/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option
if skip_slow := not config.getoption("--runslow"):
# --runslow not given in cli: skip slow tests
skip_slow_marker = pytest.mark.skip(reason="need --runslow option to run")

for item in items:
if "slow" in item.keywords:
item.add_marker(skip_slow)
if skip_slow and "slow" in item.keywords:
item.add_marker(skip_slow_marker)

if "ws" in item.fixturenames:
item.add_marker(pytest.mark.workerstate)
Expand Down