Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup ipywidgets mocking #6918

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

graingert
Copy link
Member

@graingert graingert commented Aug 19, 2022

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@graingert graingert marked this pull request as ready for review August 19, 2022 10:36
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 42m 4s ⏱️ + 19m 12s
  3 005 tests ±0    2 920 ✔️  - 2    83 💤 +1  2 +1 
22 239 runs  ±0  21 271 ✔️ ±0  966 💤  - 1  2 +1 

For more details on these failures, see this check.

Results for commit 15905fd. ± Comparison against base commit a1d2011.

else:
setattr(Widget, attr, value)
@contextlib.contextmanager
def mock_widget():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to upstream this

@fjetter fjetter merged commit 3e3cf21 into dask:main Aug 31, 2022
@graingert graingert deleted the cleanup-ipywidgets-mocking branch August 31, 2022 11:15
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants