Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelled/resumed->rescheduled transition #6913

Merged
merged 4 commits into from
Aug 19, 2022
Merged

cancelled/resumed->rescheduled transition #6913

merged 4 commits into from
Aug 19, 2022

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Aug 18, 2022 •
edited
Loading

Closes #6685

@crusaderky crusaderky force-pushed the cancelled_rescheduled branch from 62b7f11 to 134394d Compare August 18, 2022 19:02
@crusaderky crusaderky force-pushed the cancelled_rescheduled branch from 134394d to dd07146 Compare August 18, 2022 19:03
@crusaderky crusaderky requested a review from fjetter August 18, 2022 19:20
@crusaderky crusaderky self-assigned this Aug 18, 2022
@crusaderky crusaderky marked this pull request as ready for review August 18, 2022 19:30
hendrikmakait
hendrikmakait approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion for a docstring. Thanks @crusaderky!

distributed/tests/test_reschedule.py Show resolved Hide resolved
@crusaderky crusaderky merged commit 3369af0 into dask:main Aug 19, 2022
@crusaderky crusaderky deleted the cancelled_rescheduled branch August 19, 2022 14:43
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
@crusaderky @gjoseph92
cancelled/resumed->rescheduled transition (dask#6913)
0dd4123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resumed->rescheduled is an invalid transition
2 participants
@crusaderky @hendrikmakait