Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: deprecate awaiting objects that need an async context manager #6836

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

graingert
Copy link
Member

@graingert graingert commented Aug 5, 2022

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

very drafty experiment just to see what breaks
see also:

await Client() can be done by doing something like:

def create_client(*, task_status):
    async with Client(...) as client:
        task_status.started(client)
        await sleep_forever()

async with create_task_group() as tg:
    client = await tg.start(create_client)

@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from b3c69fc to 1cd602b Compare August 5, 2022 12:09
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±  0         15 suites  ±0   6h 45m 42s ⏱️ + 22m 50s
  3 007 tests +  2    2 922 ✔️ ±0    84 💤 +  2  1 ±0 
22 255 runs  +16  21 273 ✔️ +2  981 💤 +14  1 ±0 

For more details on these failures, see this check.

Results for commit 0a86d43. ± Comparison against base commit a1d2011.

♻️ This comment has been updated with latest results.

@hayesgb hayesgb added the asyncio label Aug 5, 2022
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from 1cd602b to c402a48 Compare August 6, 2022 07:43
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch 3 times, most recently from d2a7d8a to 707dbd1 Compare August 12, 2022 12:06
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch 3 times, most recently from ad8605a to da75a75 Compare August 18, 2022 12:10
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from b8b1f20 to 0a86d43 Compare August 19, 2022 09:35
@graingert graingert mentioned this pull request Aug 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants