Use default_initializer in WorkerProcesses
#6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was refactored out in Dask and still has the same functionality. While `initialize_worker_process` does work, it does a bit more than is needed (taking a UDF to initialize too). So just use `default_initializer`. Also there is no need to handle old Dask versions here since we now pin Dask & Distributed to the exact same version. So drop the fallback code.
jakirkham
force-pushed
the
use_default_initializer
branch
from
15b7b60 to
44fff8d
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 29m 41s ⏱️ + 12m 15s Results for commit 44fff8d. ± Comparison against base commit 9e4e3ab. ♻️ This comment has been updated with latest results. |
|
Planning on merging EOD if no comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of PR ( dask/dask#9087 )
This function was refactored out in Dask and still has the same functionality. While
initialize_worker_processdoes work, it does a bit more than is needed (taking a UDF to initialize too). So just usedefault_initializer.Also there is no need to handle old Dask versions here since we now pin Dask & Distributed to the exact same version. So drop the fallback code.
pre-commit run --all-files