Log rather than raise exceptions in preload.teardown()
#6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 15 files ±0 15 suites ±0 6h 14m 10s ⏱️ - 17m 13s For more details on these failures, see this check. Results for commit 3860122. ± Comparison against base commit 5e9e97f. ♻️ This comment has been updated with latest results. |
|
rerun tests Note: rerunning gpuCI tests since those errors should be fixed by #6434 |
jrbourbeau
approved these changes
May 26, 2022
There was a problem hiding this comment.
Thanks @mrocklin -- will merge once CI finishes
EDIT: The one test failure popping up is unrelated
jrbourbeau
changed the title
preload.teardown()
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6437