Fix intermittent test_profile_plot failure #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests Note: rerunning gpuCI tests since those errors should be fixed by #6434 |
|
Wow, 100% pass now, haven't seen that in a while. Very nice! 😄 |
|
Merging in 24 hours if there are no comments |
gjoseph92
reviewed
May 27, 2022
Comment on lines
+28
to
+29
| while not len(p.source.data["left"]): | ||
| await c.submit(slowinc, 1, pure=False, delay=0.1) |
There was a problem hiding this comment.
Suggested change
| while not len(p.source.data["left"]): | |
| await c.submit(slowinc, 1, pure=False, delay=0.1) | |
| await c.submit(slowinc, 1, pure=False, delay=0.1) | |
| while not len(p.source.data["left"]): |
Is resubmitting necessary?
There was a problem hiding this comment.
Yeah, if the profiler didn't run during the task then we're screwed I think. We want to continuously run stuff until the profiler picks it up and that information arrives on the scheduler.
gjoseph92
approved these changes
May 27, 2022
Comment on lines
+28
to
+29
| while not len(p.source.data["left"]): | ||
| await c.submit(slowinc, 1, pure=False, delay=0.1) |
|
Thanks for the review @gjoseph92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6454
cc @graingert for review if you have a moment.