Handle failing plugin.close() calls during scheduler shutdown
#6450
Conversation
|
Sure. I was just being lazy. pushed up |
There was a problem hiding this comment.
Thanks @mrocklin. This looks like a reasonable addition. I've left a couple of nice-to-have, but not blocking comments
| assert "123" in out | ||
| assert "456" in out |
There was a problem hiding this comment.
It would also be nice to check that the logger exceptions also occurred as expected
| try: | ||
| await func() | ||
| except Exception: | ||
| logger.exception("Plugin call failed during scheduler.close") |
There was a problem hiding this comment.
Including the plugin name in this message would be nice because as is we just know that some plugin method failed, but not which plugin
There was a problem hiding this comment.
logger.exception includes the traceback which should include the plugin class name, although it could be a base class that fails
There was a problem hiding this comment.
Ah, thanks for pointing that out @graingert
|
rerun tests Note: rerunning gpuCI tests since those errors should be fixed by #6434 |
jrbourbeau
changed the title
plugin.close() calls during scheduler shutdown
No description provided.