Pause to disable dependency gathering #6195
Conversation
|
Maybe errant issue number? |
|
Fixed - thanks |
Unit Test Results 16 files ±0 16 suites ±0 7h 39m 42s ⏱️ + 13m 43s For more details on these failures, see this check. Results for commit 7c23586. ± Comparison against base commit 84cbb09. ♻️ This comment has been updated with latest results. |
| y = c.submit(inc, 1, key="y", workers=[b.address]) | ||
| await wait([x, y]) | ||
|
|
||
| # - z reaches worker a with higher priority than w |
There was a problem hiding this comment.
As far as I could test, this seems to be deterministic - however I can't understand if it's intentional?
There was a problem hiding this comment.
If you rely on the priorities in this test, I would suggest to set them explicitly. This not only makes the test easier to read but it is also more robust to changes in the way we calculate internal priorities, i.e. excluding user priorities.
| y = c.submit(inc, 1, key="y", workers=[b.address]) | ||
| await wait([x, y]) | ||
|
|
||
| # - z reaches worker a with higher priority than w |
There was a problem hiding this comment.
If you rely on the priorities in this test, I would suggest to set them explicitly. This not only makes the test easier to read but it is also more robust to changes in the way we calculate internal priorities, i.e. excluding user priorities.
|
|
||
| while "y" not in a.tasks or a.tasks["y"].state != "fetch": | ||
| await asyncio.sleep(0.01) | ||
| await asyncio.sleep(0.1) |
There was a problem hiding this comment.
why is this additional sleep required?
There was a problem hiding this comment.
To make sure the task remained in fetch state and didn't transition to flight
Done. However, note that the test relies on w and z to be clustered together by the batched comms. |
Closes #5702