-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark test_stress_creation_and_deletion
as xfail
#5393
Mark test_stress_creation_and_deletion
as xfail
#5393
Conversation
I'm running stress testing to see if the flaky flag actually makes the test pass. We've had several cases in the past where a flaky test would either pass on the first go or fail 10 times in a row (which highlights that the whole VM, container, or process is borked). My stress test will take 1-2 days to run. Happy to have this merged into main as a tentative fix while we wait. |
That makes sense. FWIW anecdotally this seems to help based on the CI runs for this commit that already finished over in my fork of |
…stress_creation_and_deletion-flaky
Yeah it seems it still fails in this CI job Also seeing this failure ( #3574 ) in this CI job. |
As I feared. distributed/tests/test_stress.py::test_stress_creation_and_deletion RERUN [ 86%] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marker should be changed to xfail
Thanks for reviewing @jakirkham @crusaderky! CI failures are unrelated |
test_stress_creation_and_deletion
as flakytest_stress_creation_and_deletion
as xfail
xref #5388
cc @crusaderky