Cap maximum shard size at the size of an integer #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supercedes dask#5134 Copying over the summary of that PR Works around the OpenSSL 1.0.2 bug demonstrated in issue ( dask#4538 ), except unlike PR ( dask#5115 ) which did this for reading, this does the same thing for writing. The error may be less likely to show up in the write path (as frames may simply be smaller than this limit). Still it seems like a good idea to protect against OverflowErrors from OpenSSL
|
Guessing we will want to replace this as well ( #5115 )? |
jakirkham
reviewed
Jul 29, 2021
| @@ -145,6 +145,8 @@ class TCP(Comm): | |||
| An established communication based on an underlying Tornado IOStream. | |||
| """ | |||
|
|
|||
| max_shard_size = dask.utils.parse_bytes(dask.config.get("distributed.comm.shard")) | |||
There was a problem hiding this comment.
This seems to be 64 MiB. Do we want to limit it to that? Would it be worthwhile to have a different value for TCP specifically?
There was a problem hiding this comment.
This PR doesn't change the behavior for TCP (this value is what is used by default for everything in to_frames). All it does is make sure that TLS has a possibly different value that is capped by the max int size, which I think was the intent of the other PR.
There was a problem hiding this comment.
Got it. So this was 64 MiB before?
jakirkham
reviewed
Jul 29, 2021
Co-authored-by: jakirkham <[email protected]>
jakirkham
approved these changes
Jul 29, 2021
jrbourbeau
reviewed
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #5134
Copying over the summary of that PR
Works around the OpenSSL 1.0.2 bug demonstrated in issue ( #4538 ), except unlike PR ( #5115 ) which did this for reading, this does the same thing for writing. The error may be less likely to show up in the write path (as frames may simply be smaller than this limit). Still it seems like a good idea to protect against OverflowErrors from OpenSSL
black distributed/flake8 distributed/isort distributed