-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP co-assign related root-ish tasks #4899
Closed
Closed
Commits on Jun 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7f454fd - Browse repository at this point
Copy the full SHA 7f454fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e8f7f1 - Browse repository at this point
Copy the full SHA 8e8f7f1View commit details -
Unfortunately `ts._prefix._duration_average` == -1 for all the root tasks we care about, so this won't work.
Configuration menu - View commit details
-
Copy full SHA for b12d490 - Browse repository at this point
Copy the full SHA b12d490View commit details -
Revert "matt's occupancy-based method"
This reverts commit e348a7c.
Configuration menu - View commit details
-
Copy full SHA for 064be2e - Browse repository at this point
Copy the full SHA 064be2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1484e65 - Browse repository at this point
Copy the full SHA 1484e65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5163e77 - Browse repository at this point
Copy the full SHA 5163e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9df8be - Browse repository at this point
Copy the full SHA d9df8beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b9728f - Browse repository at this point
Copy the full SHA 7b9728fView commit details
Commits on Jun 16, 2021
-
Ignore deps of root-likes. This is working well.
When a task is root-like and the previous worker is full, we don't want to use the normal `decide_worker` logic, since that only considers as candidates workers that have the deps of the dask. Since the task only has 1-5 deps, we'd only ever consider the same 1-5 workers.
Configuration menu - View commit details
-
Copy full SHA for 0fbb75e - Browse repository at this point
Copy the full SHA 0fbb75eView commit details -
Only compute `total_nthreads` when a new worker is needed, and only compute the number of dependencies once per task group. Overloads the meaning of `_last_worker` to indicate if we've decided in the past whether a TaskGroup is root-ish or not.
Configuration menu - View commit details
-
Copy full SHA for f2da0bc - Browse repository at this point
Copy the full SHA f2da0bcView commit details
Commits on Jun 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d3db281 - Browse repository at this point
Copy the full SHA d3db281View commit details -
Configuration menu - View commit details
-
Copy full SHA for c929c96 - Browse repository at this point
Copy the full SHA c929c96View commit details
Commits on Jun 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f25ed42 - Browse repository at this point
Copy the full SHA f25ed42View commit details
Commits on Jun 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f50daf1 - Browse repository at this point
Copy the full SHA f50daf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a73508 - Browse repository at this point
Copy the full SHA 3a73508View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfe37f6 - Browse repository at this point
Copy the full SHA cfe37f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b5486f - Browse repository at this point
Copy the full SHA 0b5486fView commit details -
Revert "Test both axes. I think this is excessive."
This reverts commit 0d1e2380b525b0ee7b4e60d9bee62f889ed5520b.
Configuration menu - View commit details
-
Copy full SHA for 2c2bb68 - Browse repository at this point
Copy the full SHA 2c2bb68View commit details -
Maybe avoiding -1 is excessive; I just wanted it to still work if we changed to a Py_ssize_t
Configuration menu - View commit details
-
Copy full SHA for 5e58b5a - Browse repository at this point
Copy the full SHA 5e58b5aView commit details -
Unset
_last_worker
when we lose a workerArguably would be better to check that `ws` is in (valid_workers or all_workers); downside is that the common `all_workers` would require an O(n) search, since it's only `dict_values`, not `dict`.
Configuration menu - View commit details
-
Copy full SHA for 4132583 - Browse repository at this point
Copy the full SHA 4132583View commit details -
Configuration menu - View commit details
-
Copy full SHA for df2cf70 - Browse repository at this point
Copy the full SHA df2cf70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19107d8 - Browse repository at this point
Copy the full SHA 19107d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e45244 - Browse repository at this point
Copy the full SHA 8e45244View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.