Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.9 #4460

Merged
merged 13 commits into from
Mar 3, 2021
Merged

Python 3.9 #4460

merged 13 commits into from
Mar 3, 2021

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jan 26, 2021 •
edited
Loading

Forked from #4234
Fixes #4168

jrbourbeau
jrbourbeau reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thanks for picking this up @crusaderky! FWIW I found this change 236f8af resolves the CI issue for collecting tests in the Python 3.9 build on Windows

@crusaderky crusaderky mentioned this pull request Feb 1, 2021
Merged
2 tasks
@jrbourbeau jrbourbeau mentioned this pull request Feb 4, 2021
Closed
@crusaderky
Copy link
Collaborator Author

Things look good. I fixed the systematic failures in Windows.
Running stress test tomorrow morning

@mrocklin
Copy link
Member

mrocklin commented Feb 25, 2021 via email

@crusaderky
Copy link
Collaborator Author

@mrocklin I didn't do any work on dask/dask yet. If you're happy to release them mismatched and the stress test tomorrow morning is green, then it can go in.

@crusaderky
Copy link
Collaborator Author

This is... interesting, and unexpected.
I'm getting 0% failure rate on MacOS on 3.9, vs. the 20~30% I was seeing the previous days on 3.7 and 3.8.
I need to run more stress tests to figure out if the Python version actually makes the whole thing rock solid out of the blue, or if today was just a miraculous spell for some reason, or if they changed something in the VMs that would make all python versions stable.

@jakirkham jakirkham mentioned this pull request Feb 26, 2021
Merged
@crusaderky
Copy link
Collaborator Author

All versions of Python have become rock solid on MacOS overnight (57/60 successes)

@crusaderky crusaderky closed this Feb 27, 2021
@crusaderky crusaderky reopened this Feb 27, 2021
@crusaderky crusaderky closed this Feb 27, 2021
@crusaderky crusaderky reopened this Feb 27, 2021
@crusaderky crusaderky marked this pull request as ready for review February 28, 2021 01:29
@mrocklin
Copy link
Member

mrocklin commented Feb 28, 2021 via email

@crusaderky
Copy link
Collaborator Author

@mrocklin yes. This is ready to go. However I had a chat with @jrbourbeau and he's of the advice that this shouldn't be merged until the matching PR on dask/dask is ready too (I'm starting it now; should be quick)

@crusaderky crusaderky mentioned this pull request Feb 28, 2021
Merged
jrbourbeau
jrbourbeau approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky! It's great to see this go in

@jrbourbeau jrbourbeau merged commit ff937b9 into dask:master Mar 3, 2021
@crusaderky crusaderky deleted the python39 branch March 4, 2021 10:44
@jrbourbeau jrbourbeau mentioned this pull request Mar 6, 2021
Closed
@tonal tonal mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.9 compatibility
3 participants
@crusaderky @mrocklin @jrbourbeau