Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup new exception traceback #4125

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

KrishanBhasin
Copy link
Contributor

I was browsing the latest changelog and stumbled across this tiny change, as per my most recent PRs

@mrocklin
Copy link
Member

Thanks @KrishanBhasin . I'll admit to not knowing much about when this change would or would not be preferred. Can I ask you to explain the motivation a little?

@KrishanBhasin
Copy link
Contributor Author

KrishanBhasin commented Sep 28, 2020

Hi @mrocklin, this is very similar to a previous PRs I have raised at #4042 and #4054

When the error is raised, the message will be slightly clearer for the user:

The above exception was the direct cause of the following exception:

instead of

During handling of the above exception, another exception occurred:

@mrocklin mrocklin merged commit a968158 into dask:master Sep 28, 2020
@mrocklin
Copy link
Member

Thanks @KrishanBhasin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants