Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TaskState instances are released on Scheduler and Worker #6250

Open
3 tasks
fjetter opened this issue Apr 29, 2022 · 2 comments · Fixed by #6525
Open
3 tasks

Ensure TaskState instances are released on Scheduler and Worker #6250

fjetter opened this issue Apr 29, 2022 · 2 comments · Fixed by #6525
Assignees

Comments

@fjetter
Copy link
Member

fjetter commented Apr 29, 2022

There are strong references on our TaskState instances, Scheduler and Worker instances

See for instance #6246

We should ensure that TaskState is are properly cleaned up

Caveat: This depends on the profiler thread so we may need to relax the above tests and replace them with a more robust, less strict version as appropriate

#6246

@sjperkins
Copy link
Member

This PR address Scheduler instance leaks

mrocklin pushed a commit that referenced this issue May 25, 2022
…6421)

Adds a Lock to distributed.profile to enable better concurrency control. In particular, it allows running garbage collection without a profiling thread holding references to objects, which is necessary for #6250.
@fjetter fjetter assigned fjetter and unassigned hendrikmakait Jun 15, 2022
@fjetter fjetter linked a pull request Jun 15, 2022 that will close this issue
2 tasks
@gjoseph92
Copy link
Collaborator

I don't believe this was fully closed; #6525 was just the first step to being able to track it.

@gjoseph92 gjoseph92 reopened this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants