Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of tornado.IOLoop.run_sync #6049

Closed
1 of 3 tasks
Tracked by #6047
fjetter opened this issue Apr 1, 2022 · 1 comment
Closed
1 of 3 tasks
Tracked by #6047

Remove deprecated usage of tornado.IOLoop.run_sync #6049

fjetter opened this issue Apr 1, 2022 · 1 comment
Assignees

Comments

@fjetter
Copy link
Member

fjetter commented Apr 1, 2022

As one of the first steps of removing the tornado IOLoop from the code bas is to remove the usage of IOLoop.run_sync in favour of asyncio.run. The two have semantic differences and require us to touch the way we set up a few of our tests. The way tornado interacts with the event loop via IOLoop.run_sync is deprecated in CPython. This usage is connected to multiple warnings like "pending task while loop is closing", "task not awaited", etc.

Requirements

  • Deprecated call to IOLoop.run_sync has been replaced by asyncio.run as appropriate

Implementation notes

@fjetter fjetter changed the title Replace tornado.IOLoop.run_sync with asyncio.run Remove deprecated usage of tornado.IOLoop.run_sync Apr 20, 2022
@fjetter
Copy link
Member Author

fjetter commented Aug 5, 2022

Closing this. The remaining work can be done as part of #6163

@fjetter fjetter closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants