make regression metrics 'multioutput' behavior consistent with scikit-learn (fixes #818) #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #818.
Fixes #819.
Changes in this PR
compute
argument whenmultioutput == "raw_values"
multioutput=None
matches the behavior of their scikit-learn equivalentsnp.average()
in regression metricsmultioutput
Background
See the linked issues for an explanation. I believe this PR is worth accepting because it will resolve an inconsistency with
scikit-learn
and withdask-ml
itself, but it is technically a breaking change.Thanks for your time and consideration.