Configuration #75
Merged
Configuration #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
force-pushed
the
config-2
branch
4 times, most recently
from
b986806 to
49b9446
Compare
|
I've removed the RFC label. This is hypothetically ready to merge. Critical feedback welcome. |
jhamman
reviewed
May 8, 2018
dask_kubernetes/core.py
Outdated
| @@ -381,6 +392,8 @@ def scale_up(self, n, pods=None, **kwargs): | |||
| -------- | |||
| >>> cluster.scale_up(20) # ask for twenty workers | |||
| """ | |||
| if dask.config.get('kubernetes.count.max') is not None: | |||
| n = min(n, dask.config.get('kubernetes.count.max')) | |||
There was a problem hiding this comment.
Would it be worth issuing a warning when n > kubernetes.count.max? This may lead to surprising behavior when you can't scale beyond a certain threshold because of a parameter you didn't set.
jhamman
reviewed
May 8, 2018
This was referenced May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating configuration in dask/dask#3432
This affects downstream projects and makes it a bit easier for them to handle their own configuration files.
This PR shows how that configuration system might be used within dask-kubernetes. Review would be welcome. I recommend reading the documentation provided within dask/dask#3432 first.
cc @jacobtomlinson