Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use capture_output or update minimum Python version #269

Closed
holdenk opened this issue Sep 27, 2020 · 3 comments · Fixed by #273
Closed

Don't use capture_output or update minimum Python version #269

holdenk opened this issue Sep 27, 2020 · 3 comments · Fixed by #273

Comments

@holdenk
Copy link

holdenk commented Sep 27, 2020

What happened:

Exception ignored in: <object repr() failed>
Traceback (most recent call last):
  File "/home/holden/repos/scalingpythonml/venv_dask/lib/python3.6/site-packages/distributed/deploy/cluster.py", line 98, in __del__
    if self.status != Status.closed:
AttributeError: 'HelmCluster' object has no attribute 'status'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/holden/repos/scalingpythonml/scratch/dask-kubernetes/dask_kubernetes/helm.py", line 79, in __init__
    encoding="utf-8",
  File "/usr/lib/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'

What you expected to happen:

Connect to cluster

Minimal Complete Verifiable Example:

Create a virtual env with Python 3.6

from dask_kubernetes import HelmCluster
cluster = HelmCluster(release_name="myrelease")

Anything else we need to know?:

Environment:

  • Dask version: dask==2.27.0
  • Dask Kubernetes Version: -e [email protected]:dask/dask-kubernetes.git@fdb77c0#egg=dask_kubernetes
  • Python version: Python 3.6.9 (default, Jul 17 2020, 12:50:27)
  • Operating System: DISTRIB_DESCRIPTION="Ubuntu 18.04.5 LTS"
  • Install method (conda, pip, source): pip
@mrocklin
Copy link
Member

mrocklin commented Sep 28, 2020 via email

@quasiben
Copy link
Member

quasiben commented Oct 1, 2020

@holdenk thanks for checking out dask-kubernetes. To give a bit more context for @mrocklin's comment, the Dask and many projects within the PyData community are moving away from Python 3.6 because NumPy is dropping 3.6 support.
Pandas, for example, dropped 3.6 support last week.

dask/community#66 for even more reading :)

@holdenk
Copy link
Author

holdenk commented Oct 2, 2020

I think updating this to 3.7 is the right thing to do, we're also pushing minimum versions forward more aggressively in Spark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants