ENH: Allow add_intercept for unknown dims #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm actually working on reversing this assumption now in #43 where we need to have multiple chunks along the columns because they are arrays of different types. |
|
Ah, right. I'll rewrite this to handle that properly then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this for https://gist.github.com/TomAugspurger/30ec08cc29810b57b4cb4458828e46c9
Fixes #13 (I think)
One side issue: is it safe to assume that
Xwill always be chunked only along the rows? Perhaps we should add a utility method that rechunks so this is true (will have to rely on dask/dask#2251)