-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start building and publishing conda nightlies #986
Conversation
… are available" This reverts commit cf72631.
|
@fjetter I discussed this a bit with @charlesbluca. It looks like dask-expr’s The options are probably:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca. Btw, a commit just got pushed to dask/dask
, so there should be a new nightly build uploaded shortly which should fix CI here (based off our offline conversation earlier today)
Thanks @jrbourbeau! Just pulled the latest changes to retrigger CI, looks like that resolved the conda issues 🎉
This is correct, and I filed dask/community#369 to track efforts to make these versions consistent.
I don't think this is the case, I think the main reason the check failed before (as opposed to now) is that before the latest That being said, we shouldn't have had to wait for a random commit to land in the repo post-release to unblock things here, which is why I opened dask/dask#11014 so that, moving forward, the normal release process of pushing a tag to dask/dask will trigger a nightly build/publish and resolve this blocker immediately. |
@jrbourbeau - Any objections to getting this in? |
Yes, @charlesbluca is right. Thanks for the correction! |
No objection from me generally. That said, I think we still need to add the conda token as a repo secret for uploading, right? EDIT: Or is that handled at a higher level, like the dask org? |
My understanding from this comment when we first set up nightlies is that it was set at the org level? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca!
Looks like you were correct @jrbourbeau: https://github.com/dask/dask-expr/actions/runs/8426623516/job/23075334138 |
Okay yeah, @charlesbluca shared this link with me offline: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-organization
Seems like dask-expr needs to be granted access from a dropdown list at the org level. |
I updated the |
Thanks @quasiben! Looks like that unblocked publishing nightlies: https://github.com/dask/dask-expr/actions/runs/8437562794/job/23107649428 I've opened dask/distributed#8601 to apply the necessary changes to the |
Great, thanks @charlesbluca @rjzamora @quasiben for handling this |
Should unblock the issues around pinning described in dask/distributed#8575 (comment)