Xarray and Dask Example

[jhamman]

cc @mrocklin

[guillaumeeb]

Finally I might be able to better understand Xarray (OK, did not took the time to dive in it yet).

Nice the PR with integrated binder!

Some problem here though, seems like the Notebook won't use Dask, not sure why. I did start the LocalCluster though. Maybe something in load_dataset?

[jhamman]

ping @rabernat and @shoyer for a review of the content.

[jhamman]

This is ready for a proper review. Tests were failing earlier due to some churn leading up to the 0.11 release of xarray. That's all behind us now and things are now in a good place.

[mrocklin]

I'll take another look at this this afternoon for style consistency.

Is there anyone who should review this on the Xarray side?

[jhamman]

We can ask @shoyer and @rabernat to take a look.

[mrocklin]

Some micro-feedback:

• I recommend merging cells 2 and 3, there doesn't seem to be a reason to keep them separate, and I like to minimize cells when possible.
• Is the da pronoun standard in xarray? If not then maybe replace with air? The da pronoun slightly conflicts with dask.array
• We make da_smooth but don't do anything with it. Is this intended?
• Ah, I see that we use it below. Would it make sense to move it down there?

These are small bits of feedback though. In general I'm more than happy to merge this as-is.

[jhamman]

@mrocklin - I'll address most of these. Yes, the da pronoun is common in xarray (da = DataArray()). This follows the standard usage of df for Pandas' DataFrame. I now this conflicts with dask.array so I'll adjust this accordingly.

[mrocklin]

I think it's totally fine to use da if it's conventional for xarray. I was just checking.

…

On Fri, Nov 9, 2018 at 1:30 PM Joe Hamman ***@***.***> wrote: @mrocklin <https://github.com/mrocklin> - I'll address most of these. Yes, the da pronoun is common in xarray (da = DataArray()). This follows the standard usage of df for Pandas' DataFrame. I now this conflicts with dask.array so I'll adjust this accordingly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszNRNqYxW0_06ZPLxa78UyhKo7HTMks5utcmxgaJpZM4YM4Qt> .

[jhamman]

I addressed all of your comments, except the da one which I think we've agreed to let slide.

[mrocklin]

Merging tomorrow if there are no further comments from xarray folks

…

On Fri, Nov 9, 2018 at 5:34 PM Joe Hamman ***@***.***> wrote: I addressed all of your comments, except the da one which I think we've agreed to let slide. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszMVKLRDJAVKmj5467nWfWCRlHrqGks5utgLvgaJpZM4YM4Qt> .

[jhamman]

Okay, @mrocklin - this is good to go.

[mrocklin]

Thanks for setting this up @jhamman !