Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool): use tmsync.Waker when txs are available #761

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 12, 2024

Issue being fixed or feature implemented

Small refactor to reuse already implemented tmsync.Waker instead of chan.

What was done?

Replaced txsAvailable chan struct{} with tmsync.Waker

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review March 12, 2024 16:35
@lklimek lklimek enabled auto-merge (squash) March 13, 2024 08:52
@lklimek lklimek disabled auto-merge March 13, 2024 11:36
@lklimek lklimek marked this pull request as draft March 13, 2024 11:36
@lklimek lklimek marked this pull request as ready for review March 13, 2024 12:05
@lklimek lklimek enabled auto-merge (squash) March 13, 2024 12:20
@lklimek lklimek merged commit c2c4ecd into v0.14-dev Mar 13, 2024
15 checks passed
@lklimek lklimek deleted the refactor/consensus-txs-available branch March 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants