Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): remove not needed commit timeout and unused LastPrecommits #751

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 7, 2024

Issue being fixed or feature implemented

We don't need LastPrecommits because they are only used in Tenderdash to construct commit.
In our case, it's enough to just set LastCommit, as we use threshold signatures and don't need these precommits.

It also means we don't need to wait for all precommits to get to our node, so commit timeout is not needed.

What was done?

Removed LastPrecommits.

Removed consensus params: commit timeout and bypass_commit_timeout.

How Has This Been Tested?

GHA + tested during stress tests on ouzo devnet

Breaking Changes

Changed definition of consensus params: removed timeout commit and bypass_commit_timeout.
Affects protobuf and json encoding of these params.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

We don't need LastPrecommits because they are only used in Tenderdash to construct commit.

In our case, it's enough to just set LastCommit, as we use threshold signatures and don't need these precommits.
@lklimek lklimek changed the title refactor: remove unused LastPrecommits refactor(consensus): remove not needed commit timeout and unused LastPrecommits Mar 8, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 37870a8 into v0.14-dev Mar 12, 2024
16 checks passed
@lklimek lklimek deleted the refactor/remove-last-precommits branch March 12, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants