Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor improvements: logging, comments, locks #726

Merged
merged 127 commits into from
Mar 13, 2024
Merged

chore: minor improvements: logging, comments, locks #726

merged 127 commits into from
Mar 13, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jan 15, 2024 •
edited
Loading

Issue being fixed or feature implemented

Various minor changes and improvements.

What was done?

  1. Improved some logs
  2. Improved code comments
  3. Fix: Remove transactions from mempool not reflected in prometheus stats

How Has This Been Tested?

GHA, Dash Platform testing

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek added 30 commits January 8, 2024 20:56
@lklimek
feat: socket client uses pririority queue to determine processing order
8fc733f
@lklimek
chore(consensus): add timing debug to makeProposal
7311bde
@lklimek
build: update go.mod/go.sum
4ef1833
@lklimek
chore: socket client debug
ea83b4f
@lklimek
chore: change abci client priorities
98025f6
@lklimek
feat: abci client prometheus support
0bbe9bd
@lklimek
fix(e2e): panic when no key provided in e2e test
91aa568
@lklimek
chore: fix typo
0568723
@lklimek
chore: add missing NoopCloser
73f5c57
@lklimek
chore: abciclient metrics
e86d67b
@lklimek
chore: abci metrics remove SentMessagesTotal which is a duplicate
f61dfd5
@lklimek
refactor!: remove consensus params commit timeout
ff8c2f3
@lklimek
chore: remove unused consensus params - backward-compat way
b9c498a
@lklimek
chore: proto abci version revert
1eefd46
@lklimek
feat(p2p): throttled channel
5e41958
@lklimek
feat: limit mempool broadcast to 5/s
cdde233
@lklimek
refactor(p2p): move chan descs to p2p.channel_params and tune priorities
f356737
@lklimek
feat: detect non-deterministic ResponsePrepareProposal
6a142e7
@lklimek
chore: decrease log size
1f0e9d9
@lklimek
chore: more debug
5b2a393
@lklimek
fix(consensus): propose locked block when it is available
6be0eaa
@lklimek
chore: improve logs
f75ae58
@lklimek
fix(consensus): ValidBlock must be equal LockedBlock
51317c5 
https://arxiv.org/abs/1807.04938
@lklimek
fix(consensus): publish valid block event if it's updated
07beb3f
@lklimek
chore: improve log readability
cc457a6
@lklimek
chore: log num txs of complete proposal block
b0224ef
@lklimek
chore(mempool): log when txs are processed
2109237
@lklimek
chore(mempool): add timeout of checktx for p2p messages
80f3c9c
@lklimek
chore(p2p): remove unneeded stopMtx from MConnection
66186bd
@lklimek
chore(p2p): further debugging
23cb8c6
@lklimek lklimek changed the base branch from v0.14-dev to feat/rate-limiting-channels March 12, 2024 09:14
@lklimek lklimek changed the base branch from feat/rate-limiting-channels to refactor/move-channel-definitions March 12, 2024 09:39
Base automatically changed from refactor/move-channel-definitions to v0.14-dev March 12, 2024 16:07
@lklimek lklimek changed the title Fix mempool spam chore: minor improvements: logging, comments, locks Mar 13, 2024
@lklimek lklimek marked this pull request as ready for review March 13, 2024 12:26
shumkov
shumkov previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shumkov
shumkov approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 46260b8 into v0.14-dev Mar 13, 2024
15 checks passed
@lklimek lklimek deleted the fix-mempool-spam branch March 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov